[DBMON-6548] Add Mysql global wait_event query metric#23562
Open
eric-weaver wants to merge 2 commits intomasterfrom
Open
[DBMON-6548] Add Mysql global wait_event query metric#23562eric-weaver wants to merge 2 commits intomasterfrom
eric-weaver wants to merge 2 commits intomasterfrom
Conversation
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 5a3fc6a | Docs | Datadog PR Page | Give us feedback! |
Contributor
Validation ReportAll 20 validations passed. Show details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
sethsamuel
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new set of metrics for
events_waits_summary_global_by_event_namewhich will get us high level instance wide visibility into global wait event summaries. This will supplement the wait_events we track and surface within DBM from Query Samples by allowing us to get un-sampled wait_event data.Motivation
Currently our wait event visibility is restricted to sampled queries. Since we sample in flight queries only and sample at a 1s interval, we currently miss visibility into many sub-second queries from samples. Having visibility into time spent instance wide in wait_events will allow us to remove some of the biased visibility we have from longer running queries and allow performance attribution to overall instance health trends.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged